Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip checks involving wildcard generic type arguments #1137

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Skip checks involving wildcard generic type arguments #1137

merged 2 commits into from
Jan 31, 2025
+41 −0

Conversation

msridhar
Copy link
Collaborator

We need to handle wildcards eventually, but in the meantime, avoid reporting false positives.

Fixes #1126

@msridhar msridhar marked this pull request as draft January 30, 2025 01:28
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (427fa89) to head (6fa9e4b).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1137      +/-   ##
============================================
- Coverage     88.26%   88.24%   -0.03%     
- Complexity     2259     2260       +1     
============================================
  Files            85       85              
  Lines          7302     7305       +3     
  Branches       1455     1457       +2     
============================================
+ Hits           6445     6446       +1     
- Misses          430      431       +1     
- Partials        427      428       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar marked this pull request as ready for review January 30, 2025 18:44
@msridhar
Copy link
Collaborator Author

The reduction in test coverage is due to this condition never being true in our tests:

NullAway/nullaway/src/main/java/com/uber/nullaway/generics/CheckIdenticalNullabilityVisitor.java

Lines 27 to 30 in 427fa89

if (rhsType.getKind().equals(TypeKind.WILDCARD)) {
// TODO Handle wildcard types
return true;
}

I think we could just delete this check now, but I'd rather leave it in since I'm not 100% sure.

@msridhar msridhar mentioned this pull request Jan 31, 2025
Closed
@msridhar msridhar merged commit 90265c5 into master Jan 31, 2025
11 of 12 checks passed
@msridhar msridhar deleted the issue-1126 branch January 31, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayutture akshayutture akshayutture approved these changes

@yuxincs yuxincs Awaiting requested review from yuxincs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type parameter nullability mismatch when using @Nullable T with ? extends @Nullable T
2 participants
@msridhar @akshayutture